TCK validator BKM typeRef #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarilabs
force-pushed
the
tarilabs-20210905
branch
from
e98ae9c
to
5ffecd9
Compare
|
Demonstrating the GHA runner failure for the TCK Validator https://github.com/dmn-tck/tck/pull/468/checks?check_run_id=3517372502
|
|
Commit demo2 f8d7dc9
|
|
Looks good to me. Thanks @tarilabs |
|
discussed in meeting TCK 2021-10-14, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of:
for the BKM's variable/encapsulatedLogic typeRef.
As discussed in the meeting, we can at least detect when it's clearly not a function, and we were expecting a function type to be the in the BKM's variable/encapsulatedLogic typeRef --the return type is expected in the "body" encapsulatedLogic.expression typeRef
Please ignore
9999-dummy-test-01.xmlwhich has no functional scope in this PR.This also fixes a potential XXE vulnerability