Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: babel-plugin-macros isn't an optional peer anymore #88

Closed
3 tasks done
SuperchupuDev opened this issue Feb 10, 2024 · 1 comment · Fixed by #89
Closed
3 tasks done

🐛 Bug: babel-plugin-macros isn't an optional peer anymore #88

SuperchupuDev opened this issue Feb 10, 2024 · 1 comment · Fixed by #89
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@SuperchupuDev
Copy link

SuperchupuDev commented Feb 10, 2024 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

babel-plugin-macros being an optional peer

Actual

it no longer is an optional peer right now in main

Additional Info

It looks like #60 got undone in #55, which might be a mistake as there's not a good reason to include a babel plugin as a package dependency. Maybe it should be a devDependency if the maintainers aren't willing to move it as a peer dep like the plugin says it should be installed
@SuperchupuDev SuperchupuDev added the type: bug Something isn't working :( label Feb 10, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Feb 10, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 17, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Feb 18, 2024
@JoshuaKGoldberg
fix: switch babel-plugin-macros to a peer dependency (again) (#89)
625d708 
## PR Checklist

- [x] Addresses an existing open issue: fixes #88
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/dmnd/dedent/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/dmnd/dedent/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Re-applies #60 per the issue.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.5.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: switch babel-plugin-macros to a peer dependency (again) dmnd/dedent
2 participants
@JoshuaKGoldberg @SuperchupuDev