Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: convert dedent.ts and tests to TypeScript #51

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Conversation

JoshuaKGoldberg
Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 17, 2023

Fixes #50.

Integrates with a few tools:

  • TypeScript itself for type checking (yarn tsc)
  • Babel's TypeScript preset to stick with the existing output process (yarn build:legacy, yarn build:modern)
  • tsup to generate a single .d.ts from dedent.ts (yarn build:types)

Types are moved from index.d.ts to dist/dedent.d.ts to match the other dist/* files. I confirmed with the attw cli that these support various Node resolution strategies.

macro.js and macro.d.ts are untouched, per #50 -> #52.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review July 17, 2023 15:04
@JoshuaKGoldberg JoshuaKGoldberg merged commit 7d735a5 into main Jul 17, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the typescript branch July 17, 2023 15:14
@JoshuaKGoldberg
Copy link
Collaborator Author

JoshuaKGoldberg commented Jul 17, 2023

Published as dedent@1.1.0 (#53).

JoshuaKGoldberg pushed a commit that referenced this pull request Aug 3, 2023
This library has already converted to TypeScript since
#51.
So, I removed files related to Flow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert dedent.ts and tests to TypeScript
1 participant