Nextjs improvements #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dmno ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for signup-api canceled.
|
theoephraim
force-pushed
the
nextjs-improvements
branch
4 times, most recently
from
9510d05
to
db38a38
Compare
theoephraim
force-pushed
the
nextjs-improvements
branch
2 times, most recently
from
16430aa
to
5208572
Compare
philmillman
reviewed
Jul 17, 2024
philmillman
approved these changes
Jul 17, 2024
packages/docs-site/src/content/docs/docs/get-started/security.mdx
Outdated
Show resolved
Hide resolved
packages/docs-site/src/content/docs/docs/integrations/nextjs.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| :::note | ||
| In general, these features should _just work_ but the matrix of app/pages router, node/edge, pages/api, and hosting platforms means that things are quite complicated. If you notice any issues, please <BugReportLink label='integrations/nextjs'>report them to us on GitHub</BugReportLink>! | ||
| ::: |
theoephraim
force-pushed
the
nextjs-improvements
branch
from
5208572
to
e92d512
Compare
next.js integration now working correctly on vercel and with various security features enabled in all the modes app/pages, node/edge, page/api, etc additional refactoring and cleanup of related code
theoephraim
force-pushed
the
nextjs-improvements
branch
from
e92d512
to
93f1e47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NextJS integration now fully working, and tested with vercel deployments.
Security features (log redaction, leak detection, http interception) now all working in all scenarios (edge+node runtimes, app + pages router, api routes + pages, etc etc...) The matrix is very large and nextjs handles everything slightly differently in each case, so I'm sure we'll find some bugs with some real world usage.
Along the way, we refactored some things, running all leak detection through a single helper, and adding a service setting to enable/disable.
Also had to temporarily make the http interception only work with fetch, because the other interceptors break edge builds. Will need to figure out a way to make 2 builds, but it's all a bit awkward so will come back to it.