Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☕ support to track location with pygeoip #42

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

agusmakmun
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.5%) to 83.333% when pulling c71ea0f on agusmakmun:develop into a1a5884 on dmpayton:develop.

Copy link

@pydanny pydanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the whitespace changes from this pull request. During a pull request review, they serve to obfuscate code changes, forcing the reviewer to go over them line-by-line, taking them away from the functionality you are added.

Also, you added a translation file. That should be mentioned in the pull request description.

user_agent = models.TextField(_("user-agent"), blank=True, null=True)
timestamp = models.DateTimeField(_("timestamp"), auto_now_add=True)
path = models.TextField(_("path"), blank=True, null=True)
username = models.CharField(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't include whitespace changes in this pull request. Makes it much harder for @dmpayton to review. For reference, whitespace changes should be in its own pull request.

Copy link
Author

@agusmakmun agusmakmun Feb 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, this because I using python-autopep8.. I'll update for it.. thank you for reviewed..

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a command of django-admin makemessages [args] it should automatically reconfigure the number of message, an example from admin_honeypot/admin.py:21 to admin_honeypot/admin.py:26 (whithout changing the previous message).

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.5%) to 83.333% when pulling 1c47fda on agusmakmun:develop into a1a5884 on dmpayton:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.5%) to 83.333% when pulling 1c47fda on agusmakmun:develop into a1a5884 on dmpayton:develop.

@blag
Copy link

blag commented Nov 26, 2021

Hi, I have forked this project, included a few PRs, and released a package to PyPI.

I would be interested in offering this feature as an option. If you're interested, please open a PR at that repo. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants