Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing template vars to context data #76

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

GitRon
Copy link

@GitRon GitRon commented Sep 1, 2020

Fixes #62

@denizdogan
Copy link

@dmpayton I'm sorry if you're swamped with other tasks, but is there any chance this will get looked at soon? :) Thanks.

@GitRon
Copy link
Author

GitRon commented Dec 4, 2020

@dmpayton @9mido Pipeline is fixed and PR is ready to merge.

@9mido
Copy link

9mido commented Dec 7, 2020

@GitRon Awesome job!

@GitRon
Copy link
Author

GitRon commented Dec 14, 2020

@dmpayton @9mido Would be awesome if somebody could review and merge it 😃

admin_honeypot/views.py Outdated Show resolved Hide resolved
@blag
Copy link

blag commented Nov 26, 2021

Hi, I have forked this project, included a few PRs (including this one), and released a package to PyPI. You might have better luck with my fork.

@GitRon
Copy link
Author

GitRon commented Nov 26, 2021

@blag Thx for your effort!

@dmpayton
Copy link
Owner

@GitRon I just pushed a commit to develop that I think resolves the issue. The relevant bit is here:

https://github.com/dmpayton/django-admin-honeypot/blob/develop/admin_honeypot/views.py#L40

Basically, just grab the default context for every Django admin view, instead of rebuilding that list manually and having to keep up with Django's own updates. What do you think?

@GitRon
Copy link
Author

GitRon commented Jan 3, 2022

Hi @dmpayton! Thx for all the effort! Unfortunately, I removed the package from my application due to version conflicts. I think the solution looks good, as far as I can tell.

Will you release a new version soon, after fixing so many issues? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined template variables make page look different than default Django login page
6 participants