reduce code with array desctructuring

dmstern · Nov 26, 2018 · 09262b9 · 09262b9
1 parent 635a66e
commit 09262b9
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/types/Package.ts b/types/Package.ts
@@ -117,17 +117,13 @@ export default class Package extends Searchable implements PackageMetaDataDTO  {
   }
 
   public getSearchItemText(): string[] {
-    let crafterTexts: string[] = [];
-    for (const crafter of this.crafters) {
-      crafterTexts = crafterTexts.concat(crafter.getSearchItemText());
-    }
     return [
         this.name || '',
         this.description || '',
         this.author ? this.author.toString() : '',
       ]
       .concat(this.keywords || []) // TODO: use Tag object instead.
-      .concat(crafterTexts);
+      .concat(...this.crafters.map((crafter) => crafter.getSearchItemText()));
   }
 
   public get crafters(): Crafter[] {