simplify searchItemText code #14

src/App.vue

@@ -242,32 +242,7 @@ export default class App extends Vue {
   }
 
   private getSearchItemText(item: Searchable) {
-    if (item instanceof Package) {
-      return [
-        item.name,
-        item.description,
-        item.author,
-      ].concat(item.keywords);
-    }
-    if (item instanceof Crafter) {
-      return [
-        `author:${item.name}`,
-        `crafter:${item.name}`,
-        `contributor:${item.name}`,
-        `collaborator:${item.name}`,
-        item.name,
-        item.email,
-        item.url,
-        item.initials,
-      ];
-    }
-    if (item instanceof SearchItem) {
-      return [
-        `#${item.value}`,
-        `keyword:${item.value}`,
-        `tag:${item.value}`,
-      ];
-    }
+    return item.getSearchItemText();
   }
 
   private isPackage(item: SearchItem | Package | Crafter): boolean {

types/Crafter.ts

@@ -87,6 +87,26 @@ export default class Crafter implements Searchable {
     return false;
   }
 
+  public getSearchItemText(): string[] {
+    const text: string[] = [];
+    if (this.name) {
+      text.push(
+        this.name,
+        `author:${this.name}`,
+        `crafter:${this.name}`,
+        `contributor:${this.name}`,
+        `collaborator:${this.name}`,
+      );
+    }
+    text.push(
+      this.name || '',
+      this.email || '',
+      this.url || '',
+      this.initials || '',
+    );
+    return text;
+  }
+
   public equals(other: Crafter): boolean {
     if (this.email && other.email) {
       return this.email === other.email;

types/Package.ts

@@ -115,6 +115,14 @@ export default class Package implements PackageMetaDataDTO, Searchable  {
     return false;
   }
 
+  public getSearchItemText(): string[] {
+    return [
+        this.name || '',
+        this.description || '',
+        this.author ? this.author.toString() : '',
+      ].concat(this.keywords  || []);
+  }
+
   public get crafters(): Crafter[] {
     if (this.craftersList.length) {
       return this.craftersList;

types/SearchItem.ts

@@ -25,4 +25,12 @@ export class SearchItem implements Searchable {
     }
     return false;
   }
+
+  public getSearchItemText(): string[] {
+    return [
+      `#${this.value}`,
+      `keyword:${this.value}`,
+      `tag:${this.value}`,
+    ];
+  }
 }

types/Searchable.ts

@@ -2,4 +2,5 @@ import Package from './Package';
 
 export default interface Searchable {
   matches(other: Searchable, packages: Package[]): boolean;
+  getSearchItemText(): string[];
 }