PackageDetail: improve download link behaviour, icon, email-link label

dmstern · Nov 19, 2018 · aa4acbd · aa4acbd
1 parent eb45ff9
commit aa4acbd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/src/components/ExternalLink.vue b/src/components/ExternalLink.vue
@@ -1,7 +1,7 @@
 <template>
   <a
     :href="href"
-    target="_blank"
+    :target="newTab === false ? '' : '_blank'"
     :title="title"
   >
     <img :src="img" v-if="img">
@@ -21,6 +21,7 @@ export default class ExternalLink extends Vue {
   @Prop() private text?: string;
   @Prop() private icon?: string;
   @Prop() private img?: string;
+  @Prop() private newTab?: boolean;
 }
 </script>
 

diff --git a/src/views/PackageDetail.vue b/src/views/PackageDetail.vue
@@ -110,11 +110,16 @@
                       </span>
                       <span v-if="!isHighlightableType(data.activeTreeItem)">This filetype ({{`${data.activeTreeItem.type}`}}) is not supported.</span>
                     </h3>
-                    But you can download it here: <ExternalLink :href="`${baseUrl}/packageDetail/${
-                      data.currentPackage ? data.currentPackage.scope : undefined
-                      }/${$router.currentRoute.params.packageName}/${
-                        data.currentPackage ? data.currentPackage.version : undefined
-                      }/files/${encodeURIComponent(`${data.activeTreeItem.path}/${data.activeTreeItem.name}`)}?format=file`"></ExternalLink>
+                    But you can download it here:
+                    <ExternalLink
+                      :href="`${baseUrl}/packageDetail/${
+                        data.currentPackage ? data.currentPackage.scope : undefined
+                        }/${$router.currentRoute.params.packageName}/${
+                          data.currentPackage ? data.currentPackage.version : undefined
+                        }/files/${encodeURIComponent(`${data.activeTreeItem.path}/${data.activeTreeItem.name}`)}?format=file`"
+                      :newTab="false"
+                      :icon="$vuetify.icons.download"
+                    ></ExternalLink>
                   </v-alert>
                   <LoadingSpinner
                     class="transition"
@@ -300,7 +305,7 @@
                       <v-list-tile-action>
                         <v-icon>{{$vuetify.icons.email}}</v-icon>
                       </v-list-tile-action>
-                      <v-list-tile-title>mailto:{{crafter.email}}</v-list-tile-title>
+                      <v-list-tile-title>{{crafter.email}}</v-list-tile-title>
                     </v-list-tile>
                   </a>
                 </v-list>