Package detail file browser #31 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmstern
added a commit
that referenced
this pull request
Nov 26, 2018
* fix console error on loading package list * Update vuetify from 1.0.19 to 1.3.4 * Make server read package fileList * PackageDetail.vue: add tree view for fileList * PackageDetail.vue: beautify file tree icons * format code * cli: correct server and ui logs properties * PackageDetail.vue: file tree: add open animation * PackageDetail.vue: add video icons * backend: add file content service * BackendApi: fix tslint error * file content service: add version as param * BackendApi: add new fetFileContent method * vscode tasks: never scan output * tasks: format * Server: add path to file tree * BackendApi: fix promise type and xhr param * DataStore: Add getFileContent method and format code * types/Package: add property `fileList` * (WIP) PackageDetail.vue: Make code selectable in file tree * fileLister: cleanup code: fix warnings * cleanup code: typedef * format code * update vuetify to 1.3.5 * Add type TreeItem * backendApi: fix filepath concat * DataStore: cache fileContent Promise * PackageDetail.vue: open code on click and add loadingspinner * cleanup: remove function * EventBus: Add timeout error * improve error handling * PackageDetail fileContent: add timeout, error handling, find subdirfiles * remove console.log * PackageDetail: tree view: fix timeout * improve error message style * PackgeDetail tree view: get clicked label correctly * PackageDetail tree view: encode filepath to send correct request * packagedetail tree view: try to get smooth transition * format code * PackageDetail: improve treeview loading animation * DataStore: fix promise cache * DataStore: add fileContentCache * cleanup code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31