Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid status & Single type schema #63

Merged
merged 6 commits into from
May 13, 2024
Merged

Invalid status & Single type schema #63

merged 6 commits into from
May 13, 2024

Conversation

eluhr
Copy link
Contributor

@eluhr eluhr commented May 13, 2024

This PR fixes some Bugs which occurred during testing and debugging

1. There was no model rule for the status property in the WidgetContent model.
2. Due to Bug 1. the provider for the status columns in the overview and detail view throw an Undefined array key if someone set the status to something we do not expect
3. JSON Schemas with only one type e.g.: {"type": "string"} lead to an array which crashes the whole page in which the cell is rendered in. To fix that, we want the properties to always be of type array. Value of a single type schemas are made available via “value”.

@eluhr eluhr requested a review from schmunk42 May 13, 2024 07:30
@eluhr eluhr merged commit 6090adf into master May 13, 2024
@eluhr eluhr deleted the dev/el branch May 13, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants