Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish on pypi #106

Merged
merged 9 commits into from
Nov 29, 2023
Merged

Publish on pypi #106

merged 9 commits into from
Nov 29, 2023

Conversation

dmunozv04
Copy link
Owner

This PR makes it possible to publish the package on Pypi, allowing for an easier install.
Additionally, it modifies how the default config dir path is chosen. It now gets an OS-dependent location unless it's overridden by the --config-dir flag or the new iSPBTV_data_dir environment variable.
It also moves all the code to the src/ folder, following conventions.

Co-authored-by: tsia <github@tsia.de>
Co-authored-by: kot0dama <89980752+kot0dama@users.noreply.github.com>
Co-authored-by: boltgolt <boltgolt@gmail.com>
@dmunozv04
Copy link
Owner Author

@bertybuttface you might have to set the iSPBTV_data_dir env variable to data/ so your image keeps working after merging this

@dmunozv04 dmunozv04 merged commit 8c7c2cc into main Nov 29, 2023
1 of 2 checks passed
@dmunozv04 dmunozv04 deleted the publish-pypi branch November 29, 2023 11:06
@bertybuttface
Copy link
Contributor

Cheers for the heads up will take a look today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants