Refactor CLI setup script, add prompts for muting and skipping native youtube ads #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Thanks for the contribution to bring feature parity between both config editors! I'll make sure to review it when I have time |
|
Thanks @dmunozv04. I'm not married to any line here, and I know that pulling the strings out to constants can be controversial. I'm open to any feedback. I also saw that github is reporting every line as different but locally the git diff is a lot cleaner. I'm not sure if maybe it's a linefeed thing, I don't think that it's tab width or anything like that. I can look deeper if you're concerned about that at all. |
|
It does look cleaner this way. I merged new changes into the branch |
|
@ryankupk merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #149 - the CLI setup wizard only sets the
skip_adsandmute_adsconfig options to false and does not give any option to set them to true during the setup process. This change adds some minor refactorings for some things in the script like using a bespoke function for prompting the user for y/n, as well as adds prompts for skipping/muting native ads and saves the choice to the config.