Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement autoplay on/off toggle #161

Merged
merged 9 commits into from
Jun 21, 2024
Merged

Conversation

Ravioli8235
Copy link
Contributor

I have been test-driving this for at least a few weeks now on two LG tvs, works pretty well, didn't have an issue so far. If autoplay is set to false, it exits to the main screen.

#82

@dmunozv04
Copy link
Owner

I’d like to test autoplay being set on, since without the explicit flag it took some weeks to break. I’ll run it myself for a couple of weeks and let you know

@dmunozv04
Copy link
Owner

Thanks for the PR, and adding the option to both config editors!

@Ravioli8235
Copy link
Contributor Author

Sure thing, let me know how it goes.

@infowolfe
Copy link

@dmunozv04 any movement on this? the autoplay is incredibly annoying.

@dmunozv04
Copy link
Owner

@infowolfe feel free to try this image: ghcr.io/dmunozv04/isponsorblocktv:pr-161
It's based on this PR. If all goes well, this will be merged soon.

@infowolfe
Copy link

@infowolfe feel free to try this image: ghcr.io/dmunozv04/isponsorblocktv:pr-161 It's based on this PR. If all goes well, this will be merged soon.

Appreciate it, I'll test and report back.

@dmunozv04
Copy link
Owner

@Ravioli8235 I've been testing this for a while on my devices and I have to say that it works wonderfully. Thanks for your work!
The only issue I see is the panel in the tui configurator seems to try to fill the screen and not just fit around the checkbox and the description.

@Ravioli8235
Copy link
Contributor Author

Thanks, I missed that somehow, should be good now, please check it.

@dmunozv04
Copy link
Owner

@Ravioli8235 I changed it in the tcss file to add bottom padding, thanks!

@dmunozv04 dmunozv04 merged commit 49fba2f into dmunozv04:main Jun 21, 2024
2 of 3 checks passed
@dmunozv04
Copy link
Owner

@Ravioli8235 merged!

@Ravioli8235 Ravioli8235 deleted the autoplay branch June 22, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants