apache#18 Fix a few minor bugs after static code analysis

dmvk · May 15, 2018 · e334b2a · e334b2a
1 parent aea8b3a
commit e334b2a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/...tensions/euphoria/euphoria-core/src/main/java/cz/seznam/euphoria/core/util/URIParams.java b/...tensions/euphoria/euphoria-core/src/main/java/cz/seznam/euphoria/core/util/URIParams.java
@@ -429,7 +429,7 @@ public void dropParam(String name) {
     String value = remove(name);
     if (value == null) {
       throw new IllegalArgumentException(String.format(
-          "Dropping parameter \"{}\" which does not exist.", new Object[] { name }));
+          "Dropping parameter \"%s\" which does not exist.", name));
     }
   }
 

diff --git a/...phoria/euphoria-inmem/src/main/java/cz/seznam/euphoria/inmem/ReduceStateByKeyReducer.java b/...phoria/euphoria-inmem/src/main/java/cz/seznam/euphoria/inmem/ReduceStateByKeyReducer.java
@@ -313,7 +313,7 @@ private void log() {
   } // ~ end of ProcessingStats
 
   static final class ScopedStorage {
-    final class StorageKey {
+    static final class StorageKey {
       private final Object itemKey;
       private final Window itemWindow;
       private final String storeId;

diff --git a/...extensions/euphoria/euphoria-kafka/src/main/java/cz/seznam/euphoria/kafka/KafkaUtils.java b/...extensions/euphoria/euphoria-kafka/src/main/java/cz/seznam/euphoria/kafka/KafkaUtils.java
@@ -99,7 +99,7 @@ static Map<Integer, Long> getOffsetsBeforeTimestamp(
     for (String seed : servers) {
 
       String[] parsedServer = seed.split(":");
-      int port = new Integer(parsedServer[1]);
+      int port = Integer.parseInt(parsedServer[1]);
       String server = parsedServer[0];
       SimpleConsumer consumer = null;