Update codegen artifacts for react-native-test-library

Differential Revision: D59010093
dmytrorykun · Jun 25, 2024 · 65d2008 · 65d2008
1 parent 70b43bb
commit 65d2008
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 13 deletions.
diff --git a/...d/src/main/java/com/facebook/react/viewmanagers/SampleNativeComponentManagerDelegate.java b/...d/src/main/java/com/facebook/react/viewmanagers/SampleNativeComponentManagerDelegate.java
@@ -34,7 +34,7 @@ public void setProperty(T view, String propName, @Nullable Object value) {
   }
 
   @Override
-  public void receiveCommand(T view, String commandName, ReadableArray args) {
+  public void receiveCommand(T view, String commandName, @Nullable ReadableArray args) {
     switch (commandName) {
       case "changeBackgroundColor":
         mViewManager.changeBackgroundColor(view, args.getString(0));

diff --git a/...d/src/main/jni/react/renderer/components/OSSLibraryExampleSpec/OSSLibraryExampleSpecJSI.h b/...d/src/main/jni/react/renderer/components/OSSLibraryExampleSpec/OSSLibraryExampleSpecJSI.h
@@ -38,11 +38,14 @@ class JSI_EXPORT NativeSampleModuleCxxSpec : public TurboModule {
     : TurboModule(std::string{NativeSampleModuleCxxSpec::kModuleName}, jsInvoker),
       delegate_(reinterpret_cast<T*>(this), jsInvoker) {}
 
+
 private:
   class Delegate : public NativeSampleModuleCxxSpecJSI {
   public:
     Delegate(T *instance, std::shared_ptr<CallInvoker> jsInvoker) :
-      NativeSampleModuleCxxSpecJSI(std::move(jsInvoker)), instance_(instance) {}
+      NativeSampleModuleCxxSpecJSI(std::move(jsInvoker)), instance_(instance) {
+
+    }
 
     double getRandomNumber(jsi::Runtime &rt) override {
       static_assert(
@@ -54,6 +57,7 @@ class JSI_EXPORT NativeSampleModuleCxxSpec : public TurboModule {
     }
 
   private:
+    friend class NativeSampleModuleCxxSpec;
     T *instance_;
   };
 

diff --git a/...est-library/android/src/main/jni/react/renderer/components/OSSLibraryExampleSpec/States.h b/...est-library/android/src/main/jni/react/renderer/components/OSSLibraryExampleSpec/States.h
@@ -10,8 +10,6 @@
 
 #ifdef ANDROID
 #include <folly/dynamic.h>
-#include <react/renderer/mapbuffer/MapBuffer.h>
-#include <react/renderer/mapbuffer/MapBufferBuilder.h>
 #endif
 
 namespace facebook::react {
@@ -25,9 +23,6 @@ class SampleNativeComponentState {
   folly::dynamic getDynamic() const {
     return {};
   };
-  MapBuffer getMapBuffer() const {
-    return MapBufferBuilder::EMPTY();
-  };
 #endif
 };
 

diff --git a/packages/react-native-test-library/ios/OSSLibraryExampleSpec/OSSLibraryExampleSpec.h b/packages/react-native-test-library/ios/OSSLibraryExampleSpec/OSSLibraryExampleSpec.h
@@ -14,6 +14,11 @@
 #ifndef __cplusplus
 #error This file must be compiled as Obj-C++. If you are importing it, you must change your file extension to .mm.
 #endif
+
+// Avoid multiple includes of OSSLibraryExampleSpec symbols
+#ifndef OSSLibraryExampleSpec_H
+#define OSSLibraryExampleSpec_H
+
 #import <Foundation/Foundation.h>
 #import <RCTRequired/RCTRequired.h>
 #import <RCTTypeSafety/RCTConvertHelpers.h>
@@ -41,3 +46,4 @@ namespace facebook::react {
   };
 } // namespace facebook::react
 
+#endif // OSSLibraryExampleSpec_H
diff --git a/packages/react-native-test-library/ios/OSSLibraryExampleSpec/States.h b/packages/react-native-test-library/ios/OSSLibraryExampleSpec/States.h
@@ -10,8 +10,6 @@
 
 #ifdef ANDROID
 #include <folly/dynamic.h>
-#include <react/renderer/mapbuffer/MapBuffer.h>
-#include <react/renderer/mapbuffer/MapBufferBuilder.h>
 #endif
 
 namespace facebook::react {
@@ -25,9 +23,6 @@ class SampleNativeComponentState {
   folly::dynamic getDynamic() const {
     return {};
   };
-  MapBuffer getMapBuffer() const {
-    return MapBufferBuilder::EMPTY();
-  };
 #endif
 };
 

diff --git a/packages/react-native-test-library/ios/OSSLibraryExampleSpecJSI.h b/packages/react-native-test-library/ios/OSSLibraryExampleSpecJSI.h
@@ -38,11 +38,14 @@ class JSI_EXPORT NativeSampleModuleCxxSpec : public TurboModule {
     : TurboModule(std::string{NativeSampleModuleCxxSpec::kModuleName}, jsInvoker),
       delegate_(reinterpret_cast<T*>(this), jsInvoker) {}
 
+
 private:
   class Delegate : public NativeSampleModuleCxxSpecJSI {
   public:
     Delegate(T *instance, std::shared_ptr<CallInvoker> jsInvoker) :
-      NativeSampleModuleCxxSpecJSI(std::move(jsInvoker)), instance_(instance) {}
+      NativeSampleModuleCxxSpecJSI(std::move(jsInvoker)), instance_(instance) {
+
+    }
 
     double getRandomNumber(jsi::Runtime &rt) override {
       static_assert(
@@ -54,6 +57,7 @@ class JSI_EXPORT NativeSampleModuleCxxSpec : public TurboModule {
     }
 
   private:
+    friend class NativeSampleModuleCxxSpec;
     T *instance_;
   };