Add support for block strings (triple quotes) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per [GraphqQL RFC](https://facebook.github.io/graphql/draft/#sec-String-Value) and its [implementation](graphql/graphql-spec#327), block strings are being a GraphQL supported feature for a while and are used for GraphiQL documentation. This PR add support for the triple quotes (""") block string.
fermads
commented
Dec 2, 2018
| main: | ||
| # Strings begin and end with quotes, and use backslashes as an escape | ||
| # character | ||
| - match: '"' | ||
| - match: '"\w+' |
There was a problem hiding this comment.
Needed for normal strings (single double-quotes) to not match multi-line strings (triple double-quotes)
|
This is helpful. Please consider to merge it :) |
|
I don't have merge access 😢 Waiting for the repo owner to approve. |
dncrews
approved these changes
Jun 17, 2019
|
Sorry mate. I don't know how I never saw this originally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per GraphQL RFC and its implementation, block strings are part of the spec for a while as a way to add multi-line documentation to GraphQL types. This PR adds syntax highlight support for triple quotes (""") block strings.