Return valid type from Future.catchError. #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An upcoming feature to the Dart analyzer [0] will report Future.catchError [1] `onError` handlers which return values of invalid type. Currently this is not reported because the `onError` handler function type cannot be accurately expressed. An `onError` handler for `Future<T>.catchError` must be either `FutureOr<T> Function(dynamic)` or `FutureOr<T> Function(dynamic, StackTrace)`. In either case, the return type of the function is `FutureOr<T>`. This CL corrects `onError` handler(s) to return a value of a valid type. [0]: dart-lang/sdk#35825 [1]: https://api.dart.dev/dev/2.12.0-149.0.dev/dart-async/Future/catchError.html
|
This is yet another instance of coveralls failing. I really need to figure out what's going on there. Stable failures are expected, since this this is using features not supported on stable. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An upcoming feature to the Dart analyzer 0 will report Future.catchError 1
onErrorhandlers which return values of invalid type. Currently this is notreported because the
onErrorhandler function type cannot be accuratelyexpressed. An
onErrorhandler forFuture<T>.catchErrormust be eitherFutureOr<T> Function(dynamic)orFutureOr<T> Function(dynamic, StackTrace).In either case, the return type of the function is
FutureOr<T>.This CL corrects
onErrorhandler(s) to return a value of a valid type.