Skip to content
This repository has been archived by the owner on Oct 6, 2019. It is now read-only.

Added small and large icons to pages editor #111

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

valadas
Copy link
Contributor

@valadas valadas commented Oct 28, 2018

Closes #109

Summary

Adds back a UI to set icons on pages (small and large icon).
This feature was part of Dnn already and all the backend still works, it was just missing a UI to manage those images. I have tried to implement it as much as possible as the Portal Logo and favIcon for a consistent user experience

@dnfclas
Copy link

dnfclas commented Oct 28, 2018

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Consistency here matches the other implementations

@ohine ohine added this to the 1.7.0 milestone Nov 6, 2018
@ohine ohine merged commit 692aef9 into dnnsoftware:development Nov 6, 2018
@ashishpd
Copy link
Contributor

Can we include an 'after' screenshot where possible? Also, where are these icons used?

@sleupold
Copy link

@ashishpd The Icons may be used in Menu or Skin

@valadas
Copy link
Contributor Author

valadas commented Apr 13, 2019

The icons can be used anywhere, commonly in menus, skins, but anything else can access them through the TabInfo data.

Here is the screenshot of the feature @ashishpd :
image

@sleupold
Copy link

@valadas
The "Enable Scheduling" toggle doesn't seem to be connected to the icons, am I correct?
maybe both sliders need a bit more space above.

@valadas
Copy link
Contributor Author

valadas commented Apr 15, 2019

@sleupold Or all the rest needs a little bit less spacing :) Either Or.... But yeah, that could be improved, it is merged now, so maybe some other time, the feature is back at least.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back a way to set small and large icons for a page
6 participants