Skip to content
This repository has been archived by the owner on Oct 6, 2019. It is now read-only.

DNN-21317: show the pane name when put mouse hover it. #19

Merged
merged 2 commits into from
Sep 6, 2018
Merged

DNN-21317: show the pane name when put mouse hover it. #19

merged 2 commits into from
Sep 6, 2018

Conversation

zyhfish
Copy link
Contributor

@zyhfish zyhfish commented Aug 14, 2018 •
edited by tpluscode
Loading

fixes #1

@tpluscode tpluscode mentioned this pull request Aug 14, 2018
Closed
@tpluscode
Copy link
Contributor

@zyhfish could you apply this method, using content: attr(id) style and ::before selector?

I think it is a cleaner approach. @dnnsoftware/tag?

@mitchelsellers
Copy link
Contributor

@tpluscode I agree, that is much cleaner. @zyhfish can you accommodate?

@mitchelsellers mitchelsellers added this to the 1.7.0 milestone Aug 20, 2018
@dnfclas
Copy link

dnfclas commented Sep 6, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@zyhfish
Copy link
Contributor Author

zyhfish commented Sep 6, 2018

Code updated, please check, thx

@tpluscode tpluscode merged commit 295b155 into dnnsoftware:development Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tpluscode tpluscode tpluscode approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

Assignees
No one assigned
Labels
noteworthy
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Show Content Pane Labels
5 participants
@zyhfish @tpluscode @mitchelsellers @dnfclas @ohine