This repository has been archived by the owner on Oct 6, 2019. It is now read-only.
Added back host email setting in smtp server configuration #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing steps:
Context
The host email is used in a couple places in the platform, see https://github.com/dnnsoftware/Dnn.Platform/search?q=hostemail&unscoped_q=hostemail
It can also be used by module developers to send a message to the person responsible for hosting the possibly multiple sites.
Since Dnn 9 and the persona bar came out, the only way to change this host email was to edit the database directly.
closes #6
This is my first pull request for the persona bar, if I did anything wrong or not following best practices, please comment.