Fixes Event Log from Failing Silently during Application Startup (#4178)

* Added try-catch block to prevent event logs from silently failing * Updated exception handling to catch specific exception
dnnsoftware · Oct 12, 2020 · 30cd13a · 30cd13a
1 parent 83af9dd
commit 30cd13a
Showing 1 changed file with 16 additions and 8 deletions.
diff --git a/DNN Platform/Library/Services/Log/EventLog/LogController.cs b/DNN Platform/Library/Services/Log/EventLog/LogController.cs
@@ -13,6 +13,7 @@ namespace DotNetNuke.Services.Log.EventLog
     using System.Threading;
     using System.Web;
     using System.Xml;
+
     using DotNetNuke.Abstractions.Logging;
     using DotNetNuke.Common;
     using DotNetNuke.Common.Utilities;
@@ -45,14 +46,21 @@ public void AddLog(LogInfo logInfo)
                     }
 
                     if (string.IsNullOrEmpty(logInfo.LogUserName))
-                    {
-                        if (HttpContext.Current != null)
-                        {
-                            if (HttpContext.Current.Request.IsAuthenticated)
-                            {
-                                logInfo.LogUserName = UserController.Instance.GetCurrentUserInfo().Username;
-                            }
-                        }
+                    {
+                        if (HttpContext.Current != null)
+                        {
+                            try
+                            {
+                                if (HttpContext.Current.Request.IsAuthenticated)
+                                {
+                                    logInfo.LogUserName = UserController.Instance.GetCurrentUserInfo().Username;
+                                }
+                            }
+                            catch (HttpException exception)
+                            {
+                                Logger.Error("Unable to retrieve HttpContext.Request, ignoring LogUserName", exception);
+                            }
+                        }
                     }
 
                     // Get portal name if name isn't set