Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Default Module Action Menu Configurable #2762

Closed
mikesmeltzer opened this issue May 7, 2019 · 1 comment
Closed

Make Default Module Action Menu Configurable #2762

mikesmeltzer opened this issue May 7, 2019 · 1 comment
Assignees
Milestone

Comments

@mikesmeltzer
Copy link
Contributor

Follow-up to RFC #2700

Description of problem

Currently, the path to the default Module Action menu control (/admin/Menus/ModuleActions/ModuleActions.ascx) is hardcoded within the C# in the Container base class and does not allow a developer to configure the site to use a different action menu control by default on a per site basis.

The default action menu can be overridden on a per module basis by using a container that uses it's own action menu control. However, it would be ideal if we could define the action menu at a portal level and override the default action menu regardless of the container being used across the site, unless the container supplied it's own action menu as you can today.

Description of solution

Add a new Portal Setting called DefaultActionMenu, similar to how the default skin path, container path, etc. are stored.

Have the setting defaulted to the existing action menu path and allow users to swap this behaviour out by changing the setting value to point to an action menu control of their choosing.

This change would include the SQL to include the new portal setting in the DB, change the container base class to read from the portal setting instead of the hardcoded path, and changes to the Portal Settings and Portal Settings Controller to add the new setting into the API.

Affected version

This is net new functionality targeted for DNN v9.4.

Affected browser

This is a server side feature and is therefore browser agnostic.

@ohine
Copy link
Contributor

ohine commented May 21, 2019

Closing issue as PR was merged.

@ohine ohine closed this as completed May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants