-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Default Module Action Menu Configurable #2804
Conversation
…o Solution Info due to build scripts changing values locally.
Add missing objectQualifier and databaseOwner.
Wouldn't it be easier, to provide the default value in the API instead of the database table? This way, no record would be needed, unless using a custom action menu. |
@sleupold That is exactly how I have it currently. The default value is supplied in the API and if it exists in the database then it will use that one instead. You can find the defaulting in the PortalSettingsController.cs file change. For including it in the DB during install, my thought was from a discover-ability perspective that it would be easier for developers to get started using this if they could see the setting in the DB instead of it being hidden away. Since it works without the script, if the script isn't working properly then it's not a blocker to move ahead without it. |
Website/Providers/DataProviders/SqlDataProvider/09.04.00.SqlDataProvider
Outdated
Show resolved
Hide resolved
Thanks @mikesmeltzer! Is the alternative action menu something open source that you can point to, or is it custom/proprietary? |
@bdukes There aren't any alternatives at the moment. I am intending to do a blog post for the 9.4 release informing users as to what the feature is and how one would get started building their own menus. |
Thanks for the contribution @mikesmeltzer! Sorry for the confusion around the SolutionInfo file too. |
Successful build queued manually. |
Fixes issue #2762
Summary
Added a new property to the Host Setting entity that will allow solution developers to change what control get's loaded for the portal's default Module Action Menu.
Adjusted the the Container.cs class to read from the new HostSetting instead of a hard coded value.
The new behaviour will default to the core module action menu if a HostSetting entry for the new property is not found in the database,
I added a git ignore for SolutionInfo.cs as local build scripts were modifying that file to update the versioning.
Note: I've tested that the SQL script works when running manually but it is not being ran (or appears that way) when I modify a nightly 9.4 build to include this script. If someone can put another set of eyes on the script and see if they can spot the issue, if not I'd like to see if it works properly when we do a RC build (the script not running will not break the site/code but it would be nice to add the value into the DB).