Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Visual Studio Requirement to 2017 or 2019 #2784

Closed
ohine opened this issue May 14, 2019 · 4 comments
Closed

Bump Visual Studio Requirement to 2017 or 2019 #2784

ohine opened this issue May 14, 2019 · 4 comments
Milestone

Comments

@ohine
Copy link
Contributor

ohine commented May 14, 2019

Description of bug

After merging #2774 and #649 we can no longer compile the Platform or AdminExperience in Visual Studio 2015.

The current requirements for the Platform are VS2015 and for Extensions 2013 or 2015.

https://www.dnnsoftware.com/docs/developers/requirements.html
https://dnndocs.com/content/administrators/requirements/index.html#dnn-requirements

Suggested Solution

Upgrade our required version of Visual Studio to 2017 or 2019 with the Platform v9.4 release.

@ohine ohine added this to the 9.4.0 milestone May 14, 2019
@SkyeHoefling
Copy link
Contributor

@ohine I agree that #2774 made the problem visible, I believe #2758 caused the problem as that enforced all platform code to compile under C# 7.0. There were many projects in the platform that were still targeting C# 6.0. #2774 used some features that are not available in C# 6.0.

I think we need to create a issue in the Admin Experience project to get everything on C# 7.0 if it isn't already there

@ohine
Copy link
Contributor Author

ohine commented May 14, 2019

Good catch @ahoefling, I totally forgot about the C# 7.0 bump.

As for AE, yes we need to get it on C#7 and .net 4.7.2. It would be nice to do the same with CDF and CK if someone has the time to submit those PRs before Friday's v9.4.0 codefreeze.

@SkyeHoefling
Copy link
Contributor

PR Submitted dnnsoftware/Dnn.AdminExperience#948

@valadas
Copy link
Contributor

valadas commented May 14, 2019

Duplicates #2786

@valadas valadas closed this as completed May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants