Skip to content
This repository has been archived by the owner on Oct 6, 2019. It is now read-only.

replace jre based yui compressor with .net msbuild version #649

Merged
merged 5 commits into from
Apr 9, 2019

Conversation

ohine
Copy link
Contributor

@ohine ohine commented Apr 5, 2019

Summary

Closes #377

@bdukes
Copy link
Contributor

bdukes commented Apr 8, 2019

@ohine did you have a plan to address the build error:

Build\BuildScripts\Package.Targets(68,5): Error : There is no data in the file [D:\a\1\s\Extensions\Manage\Dnn.PersonaBar.Roles\admin\personaBar\css\Roles.css]. Please check that this is the file you want to compress.
Build\BuildScripts\Package.Targets(68,5): Error : Failed to read/parse data in file [D:\a\1\s\Extensions\Manage\Dnn.PersonaBar.Roles\admin\personaBar\css\Roles.css].
Build\BuildScripts\Package.Targets(68,5): Error : Value cannot be null.
Parameter name: source

I took a look at it and wasn't able to find a way to suppress the error or add some placeholder content to the CSS file to quiet the warning. Is Webpack already minifying, and the YUI step is unnecessary? Or do we just need to not target this one file?

@ohine
Copy link
Contributor Author

ohine commented Apr 8, 2019

@bdukes Yes, I was planning on circling back and getting this fixed, we definitely don't want to run YUI on the webapp folders, but I think we do want to run it on these files as yarn/webpack/etc isn't setup to process those folders.

Do we even need the roles.css file if it's empty? Can we just delete it?

@bdukes
Copy link
Contributor

bdukes commented Apr 8, 2019

After removing files related to Roles.css and references, there's now this error:

"C:\Code\Dnn.Platform\Dnn.AdminExperience\Dnn.AdminExperience.sln" (default target) (1) ->
"C:\Code\Dnn.Platform\Dnn.AdminExperience\Extensions\Manage\Dnn.PersonaBar.Roles\Dnn.PersonaBar.Roles.csproj" (default target) (17) ->
(Minification target) ->
C:\Code\Dnn.Platform\Dnn.AdminExperience\Build\BuildScripts\Package.Targets(68,5): error : At least one file is required to be compressed / minified. [C:\Code\Dnn.Platform\Dnn.AdminExperience\Extensions\Manage\Dnn.PersonaBar.Roles\Dnn.PersonaBar.Roles.csproj]

So I think the MSBuild task still needs to be adjusted :-/

@bdukes
Copy link
Contributor

bdukes commented Apr 8, 2019

@ohine I pushed a couple of commits to address those errors 🤞

@ohine
Copy link
Contributor Author

ohine commented Apr 8, 2019

@bdukes Thanks!! I was in the middle of wrapping up another issue before switching back to this! 🤞 for sure!

@bdukes
Copy link
Contributor

bdukes commented Apr 8, 2019

Looks like our checks are green, just need some approvals

@bdukes
Copy link
Contributor

bdukes commented Apr 8, 2019

Upon review, I pushed one more change to comment out the JS minification pieces to clarify that they're unused.

@mitchelsellers
Copy link
Contributor

@ohine Want this merged now?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace yuicompressor with modern tooling
3 participants