Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit Module settings after moving Module to another page #3351

Closed
8 tasks
aelibyary opened this issue Nov 28, 2019 · 1 comment · Fixed by #3353
Closed
8 tasks

Unable to edit Module settings after moving Module to another page #3351

aelibyary opened this issue Nov 28, 2019 · 1 comment · Fixed by #3353
Milestone

Comments

@aelibyary
Copy link
Contributor

aelibyary commented Nov 28, 2019

Description of bug

DNN Platform/Library/Entities/Modules/ModuleController.cs MoveModule only updates the tabid for TabModules table but not updating the tabid for ContentItems table for the same module

Steps to reproduce

List the steps to reproduce the behavior:

  1. From DB, find the latest module on the system
    select top 1 ModuleID from Modules order by 1 desc
  2. Then, select the TabModules and the ContentItems based on that moduleID
select TabID from TabModules where moduleID = {moduleID from step 1}
select TabID from ContentItems where moduleID = {moduleID from step 1}
  1. execute DNN Platform/Library/Entities/Modules/ModuleController.cs >MoveModule function giving it the moduleID, the TabID found on step 2, the new tabID , and the pane name of the new tabID
  2. select Step 2 again and notice the returned TabID

Current result

TabID of the TabModules has been updated while TabID of the ContentItems has not been updated.

Expected result

both tables should have been updated by this function.

Screenshots

Error log

[ERROR] DotNetNuke.Services.Exceptions.Exceptions - System.InvalidOperationException: This module does not belong to the page. Please move to the master page to change the module. at DotNetNuke.Entities.Tabs.TabChangeTracker.TrackModuleModification(ModuleInfo module, Int32 moduleVersion, Int32 userId)

Additional context

Add any other context about the bug that may be helpful for resolution.

Affected version

  • 10.0.0 alpha build
  • 9.4.2 alpha build
  • 9.4.1 latest supported release

Affected browser

  • Chrome
  • Firefox
  • Safari
  • Internet Explorer
  • Edge
@valadas
Copy link
Contributor

valadas commented Nov 29, 2019

For context, this is described with an Evoq specific set of steps to reproduce, but the actual issue is with the content items tabId not being updated when moving modules to a new tab, which is part of the platform.

@aelibyary aelibyary changed the title Unable to edit Visualizer settings after moving Visualizer to another page Unable to edit Module settings after moving Module to another page Nov 29, 2019
@valadas valadas modified the milestones: 10.0.0, 9.5.0 Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants