Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit Module settings after moving Module to another page #3353

Merged
merged 3 commits into from
Dec 3, 2019

Conversation

aelibyary
Copy link
Contributor

@aelibyary aelibyary commented Nov 29, 2019

Fixes #3351

Summary

Moving a module from one tab to another changes the TabId for the TabModules but wasn't changing the tabID for the ContentItems which fails later by this condition:
DNN Platform/Library/Entities/Modules/ModuleController.cs >

public bool IsSharedModule(ModuleInfo module)
        {
            var contentController = Util.GetContentController();
            var content = contentController.GetContentItem(module.ContentItemId);
            return module.TabID != content.TabID;
        }

and the fix was to update the TabID of the ContentItems as well.

@valadas valadas added this to the 9.5.0 milestone Nov 30, 2019
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @aelibyary.

@valadas are we holding off merging this one until after the official 9.4.3 release?

@valadas
Copy link
Contributor

valadas commented Dec 2, 2019

@david-poindexter yes please

@valadas valadas changed the base branch from release/9.4.x to develop December 3, 2019 22:56
@valadas valadas merged commit ff4f3b7 into dnnsoftware:develop Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to edit Module settings after moving Module to another page
3 participants