Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Logs - Add Log Setting returns 401 for admins #4398

Closed
3 tasks done
daguiler opened this issue Jan 5, 2021 · 2 comments · Fixed by #4399
Closed
3 tasks done

Admin Logs - Add Log Setting returns 401 for admins #4398

daguiler opened this issue Jan 5, 2021 · 2 comments · Fixed by #4399

Comments

@daguiler
Copy link
Contributor

daguiler commented Jan 5, 2021

Description of bug

Add Log Setting option in Admin Logs returns 401 for admins.

Steps to reproduce

  1. Open MANAGE > Admin Logs > Log Settings
  2. Click on "Add Log Setting"
  3. Enable the Logging switch, set Log Type to "Application Shutting Down"
  4. Click on "Save"

Current behavior

A "success" notification pops up saying "The log setting could not be added. Please try again later."

Expected behavior

Log setting should be added without issues, but in case an issue occurs, it should be displayed as an error, not as a successful operation.

Screenshots

image

Error information

Following error is shown in the browser's console:

Failed to load resource: the server responded with a status of 401 (Unauthorized)

and occurs when PB issues a POST request to /API/PersonaBar/AdminLogs/AddLogSetting

Additional context

It seems this behavior was introduced by this PR: dnnsoftware/Dnn.AdminExperience.Extensions#231 three years ago.
Looking in the original ticket, it seems some QA test was expecting Admin users not to be able to add Admin Log settings and therefore this condition was added, although it doens't make any sense to me.
Anyone have a clue why admins should not be able to add admin log settings?? and whether this is a mistake or it is expected behavior?

Affected version

  • 10.00.00 alpha build
  • 09.08.01 release candidate
  • 09.08.00 latest supported release
    and all the way down to 9.2.0

Affected browser

All browsers.

@bdukes
Copy link
Contributor

bdukes commented Jan 5, 2021

That doesn't make any sense to me either. Do you have access to the associated ticket, DNN-10163?

@daguiler
Copy link
Contributor Author

daguiler commented Jan 5, 2021

Here's a screenshot of the ticket, but it doesn't help much:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants