Admin Logs - Fixed Log Settings errors

[daguiler]

Fixes #4398

Summary

This pull request reverts 4d1f352 and changes the Admin Logs panel to show error notifications when Log Settings operations fail (instead of success notifications)

[daguiler]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 4399 in repo dnnsoftware/Dnn.Platform

[daguiler]

Hi @bdukes can you help me rebuild this PR?
I believe the build error is not caused by my changes

[bdukes]

@dnnsoftware/approvers do you need to be a superuser to manage log settings? It looks like there's already logic so that a non-superuser can only manage settings for their current portal. Anyone have a reason why this restriction would need to stay in place?

[sleupold]

site specific settings should be able to be managed by portal admins (and superusers), however, all system events (relevent for all sites) should be managed by superusers only.

[daguiler]

Actually, the Log Settings tab is not even displayed if you are not a super user.

[mitchelsellers]

I would agree with @sleupold on this one, and I am not 100% sure that we have the proper distinction in being able to do this within the configuration settings.

For example, an Admin should not be able to turn off logging of user logins etc.

[daguiler]

The issue that was reported to us is that admins/superusers are not allowed to add log settings. And given that this issue has been in place for more than 3 years, I think it's fair to assume that nobody is using this feature at all.
So my suggestion is to just remove this restriction (current changes in this PR) and then create a new issue describing the optimal behavior of this part of DNN.
Otherwise this will become a design change, and it would go out of scope of my bugfix.

[mitchelsellers]

I don't think we can just remove the restriction, as that changes the security profile quite a bit.. Let me chat with the others about this one.

[valadas]

I agree that this should be reserved to hosts only, admins should view the logs but not be able to add log types for instance...

[daguiler]

Ok, I agree it would have changed the security profile.
I now pushed 2 commits to fix the issue for superusers without impacting security in any other way.

[daguiler]

Thanks @bdukes
It seems Github didn't honor the encoding and/or the new line characters, so it looks like a huge change now. But if you enable the Hide whitespace changes checkbox, it will look fine.

[bdukes]

Thanks!