Add setting to display search result for users in specific roles #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyhfish
changed the title
daguiler
changed the title
daguiler
approved these changes
Jan 9, 2019
There was a problem hiding this comment.
LGTM. Things I checked:
- If a role doesn't exist anymore, it is not shown
- if role is added back, and was selected, it is shown selected again
- New portal setting is saved and loaded consistently
- Search results are shown to the user as long as the user belongs to any of the selected roles
mitchelsellers
approved these changes
Apr 9, 2019
|
the setting caption should mention that only results from indexed "users" records are affected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2533