Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade DNN to .NET Framework 4.7.2 #2644

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Upgrade DNN to .NET Framework 4.7.2 #2644

merged 2 commits into from
Mar 26, 2019

Conversation

SkyeHoefling
Copy link
Contributor

Closes: #2615

Summary

Upgrades all .csproj and .vbproj files to use .NET Framework 4.7.2. Verified the build still works and all unit tests are passing locally

Upgraded app projects to .NET Framework 4.7.2; Added missing dependen…
3818adc 
…cy to DotNetNuke.Tests.Core as it was missing DotNetNuke.Web.Client
bdukes
bdukes requested changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

DNN Platform/Admin Modules/Dnn.Modules.Console/web.config Outdated Show resolved Hide resolved
david-poindexter
david-poindexter approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SkyeHoefling
Copy link
Contributor Author

@bdukes Thanks for the feedback, I made changes as you suggested.

@SkyeHoefling SkyeHoefling mentioned this pull request Mar 25, 2019
Open
6 tasks
mitchelsellers
mitchelsellers approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for getting on this one so quickly

@SkyeHoefling
Copy link
Contributor Author

@mitchelsellers

LGTM - Thanks for getting on this one so quickly

No problem at all, another step in the right direction for the platform.

What is the milestone for this? 9.3.1 or 9.4? I want to update the Razor Pages Epic

@mitchelsellers mitchelsellers added this to the 9.4.0 milestone Mar 26, 2019
@mitchelsellers
Copy link
Contributor

Milestone will be 9.4.0. I'll merge it in with one last confirmation with @ohine

@ohine ohine merged commit 9c00ca2 into dnnsoftware:development Mar 26, 2019
@ohine ohine modified the milestones: 9.4.0, 9.3.1 Mar 26, 2019
zyhfish pushed a commit to zyhfish/Dnn.Platform that referenced this pull request Mar 29, 2019
@zyhfish
Upgrade DNN to .NET Framework 4.7.2 (dnnsoftware#2644)
ab9ed86 
* Upgraded app projects to .NET Framework 4.7.2; Added missing dependency to DotNetNuke.Tests.Core as it was missing DotNetNuke.Web.Client

* Removed targetframework web.config reference from Dnn.Modules.Console
@ohine ohine mentioned this pull request Apr 5, 2019
Merged
@ohine ohine mentioned this pull request May 14, 2019
Closed
mitchelsellers pushed a commit that referenced this pull request May 14, 2019
@mitchelsellers
Force user logout after password changed in other place. (#2509)
1cedd7d 
* DNN-27517: force user logout after password changed in other place.

* DNN-27517: update code by review.

* DNN-27517: add host settings to control whether force logout after password changed.

* NOJIRA: mark as stable.

* Fixed bugs on add/remove user permissions for modules

* Change algorithm to SHA1CryptoServiceProvider

* Updated Issue Templates to include new RFC template and to support submissions for 9.3.0 release

* Corrected structure to avoid issue linking

* code review

* User registration: end the response after redirect (#2511)

* Initial New User Email Not Sending At Time of Creation (#2492)

This is alternative way to fix above issue proposed in dnnsoftware/Dnn.AdminExperience#174

As per @sleupold , we need to move email notifications from UI to core part.
Once this will be approved and merged, we can remove email notifications from UI and replace it with updated controller method to let notifications to be send to their recipients.

fixes #2424

* Fix for missing SQL change (#2522)

Fixes #2521 by rebuilding the PortalsDefaultLanguage view

* Resolve UserProfile Loading Errors From Unsecure pages (#2494)

* NOJIRA: mark as stable.

* DNN-21637: add config key.

* DNN-26576: prevent same-origin errors when loading popup and iframes from a secure page.

* code review

* Code review

* (DNN-10795) - All pages except home page return 404 (