Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital Assets: Azure folders are slow to open #2698

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Digital Assets: Azure folders are slow to open #2698

merged 3 commits into from
Apr 16, 2019

Conversation

mikebigun
Copy link
Contributor

fixes #2697

After some investigation we found it loads Azure content using very small batches of data in a loop. On every Azure folder click, system synchronizes content and makes huge amount of iterations to upload all files. See:

resultSegment = container.ListBlobsSegmented("", true, BlobListingDetails.All, 10, continuationToken, null, null);

To improve performance, I added SyncBatchSize setting which is now available on UI. It is possible to configure size of batches to load from Azure in one call. Customer can make it configured to their needs, smaller values means we will need more round trips to fetch all files, large numbers will potentially lead to timeouts in case of big repositories, but at same time will improve performance for a small repos.

Below you'll find few changes:

  1. SyncBatchSise setting is added to UI. It gets saved in database and used to load certain number of files from Azure during one call.
  2. I did a small refactoring for the constants. I moved constant strings to one file and used it in a few places within one project.

image

image

@daguiler daguiler added this to the 9.3.2 milestone Apr 16, 2019
@daguiler daguiler added Type: Bug esw Issues reported by ESW team or Evoq customers labels Apr 16, 2019
mitchelsellers
mitchelsellers previously approved these changes Apr 16, 2019
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, appreciate the extra work to extract the constants as well!

Copy link
Contributor

@daguiler daguiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I just added a few minor suggestions.

donker
donker previously approved these changes Apr 16, 2019
Copy link
Contributor

@donker donker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

ohine
ohine previously approved these changes Apr 16, 2019
@daguiler daguiler dismissed stale reviews from ohine, donker, and mitchelsellers via 601d41f April 16, 2019 20:37
@daguiler daguiler merged commit 1e91153 into dnnsoftware:release/9.3.2 Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Localization esw Issues reported by ESW team or Evoq customers Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants