Splits the Lists table population in 500 items batches #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchelsellers
approved these changes
Apr 30, 2019
|
I did not test the syntax change but went for the minimal change that fixed the issue. I am not sure on support for the other syntax on various SQL server versions so wanted to avoid introducing that change in a bug fix release that is already in RC stage. SQL server script generation looks more like the current syntax except it generates a go in each line and has hardcoded values instead of variables. |
|
Fair enough. @ohine any thoughts |
|
Just let me know if you want me to test other solutions on that same machine since I have a good testbed to reproduce. My concern with the other solution was that it may not work everywhere (azure SQL, old versions of SQL server, etc.) Which I don't have a good testbed for. |
daguiler
approved these changes
Apr 30, 2019
ohine
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2743
Summary
This PR splits the creation of rows in the Lists table into 500 item batches intead of a single bath with more than 5000 lines. This is to prevent a timeout issue during installation on some environments.