Remove GetAzureCompactScript from SqlDataProvider #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchelsellers
approved these changes
May 7, 2019
There was a problem hiding this comment.
I have verified that the items being matched against in these modifications are fully supported by Azure SQL. Therefore, since Azure SQL can support this, I don't see this as a breaking change.
Quick performance benchmarking of the processing necessary for this code shows that overall DNN Performance should be dramatically increased.
In other words...Looks good to me!
daguiler
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GetAzureCompactScriptdoesn't appear to be required any longer for azure compatibility and it adds quite a bit of overhead to every single sql query run through the Platform. This PR removes the check and removal of the following strings.WITH\\s*\\([\\s\\S]*?((PAD_INDEX|ALLOW_ROW_LOCKS|ALLOW_PAGE_LOCKS)\\s*=\\s*(ON|OFF))+[\\s\\S]*?\\)(TEXTIMAGE_)*ON\\s*\\[\\s*PRIMARY\\s*\\]