Missing encoding in email alternate view #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is to ensure AlternativeView encoding is always consistent with bodyEncoding and not relying on the body text - Extract the code to AddAlternateView method to allow UTs
|
|
daguiler
changed the title
amarjeet
approved these changes
Jul 19, 2019
tingung
deleted the
bugfix/DNN-30859-fix-missing-encoding-in-Mail-SendMail-alternate-view
branch
13 tasks
bdukes
added a commit
to bdukes/Dnn.Platform
that referenced
this pull request
Aug 31, 2021
This functionality was inexplicably removed in b3e066f dnnsoftware#4187 Includes fixes originally from dnnsoftware#2900 (1b44e1d) Fixes dnnsoftware#2899
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2899
Summary
Set AlternativeView.Encoding with bodyEncoding
Notes: UT covered existing behavior even not part of the changes. Minor fix to the existing test method (ConvertToText_removes_styles_including_css_defs)
Confirmation Video - https://drive.google.com/file/d/1tiz3ce6gJtVrD4ZclsRX-Z3PDaryFbSr/view