Allows loading dependencies during startup even if one fails #2953
Conversation
There was a problem hiding this comment.
I reviewed this with Daniel as he created it. Additionally supporting documentation on this behavior can be found on MSDN documentation as well as here: https://haacked.com/archive/2012/07/23/get-all-types-in-an-assembly.aspx/
This looks great for now. It also begs a few additional changes for the future, but this improves the behavior now, which will substantially improve developer experience, with no impact to performance.
|
And just for the record I believe this has been there for a while. I’m not 100% sure if new behavior but for sure something we need to monitor in future PRs |
| catch (Exception) | ||
| { | ||
| { | ||
| //TODO: We should log the reason of the exception after the API cleanup |
There was a problem hiding this comment.
@valadas can we create a follow-up issue to track this //TODO. If there is already one created can you link it in this PR
| @@ -32,8 +33,15 @@ public static Type[] SafeGetTypes(this Assembly assembly) | |||
| { | |||
| types = assembly.GetTypes(); | |||
| } | |||
| catch (ReflectionTypeLoadException ex) | |||
| { | |||
| //TODO: We should log the reason of the exception after the API cleanup | |||
There was a problem hiding this comment.
@valadas can we create a follow-up issue to track this //TODO. If there is already one created can you link it in this PR
|
This looks great! Are there follow-up items created for the //TODOs? |
|
I did not create an issue for it, but the //TODO: syntax shows up in the visual studio tasks panel. The reason we have not implemented it yet is because it would have created a new dependency for the logging here and we wanted to push that to later. So maybe we can do that when we start using more dependency injection.. |
* Fix error running unit tests (#2940) When running tests, the following error occurs: VSTest: Could not locate executable. cake-build/cake#1522 (comment) indicates that there's an issue using VS 2019, and presents a workaround to find the correct path * DNN-31366 - Deleted page can still be selected as parent page (#2925) * DNN-31366 - TabController HasChildren returns false if all children are deleted * Simplify HasChildren condition * deleting_themes_from_Extensions_doesnt_remove_it_from_themes (#2950) * Returns the working types if some fail (#2953)
…e#2964) * Fix error running unit tests (dnnsoftware#2940) When running tests, the following error occurs: VSTest: Could not locate executable. cake-build/cake#1522 (comment) indicates that there's an issue using VS 2019, and presents a workaround to find the correct path * DNN-31366 - Deleted page can still be selected as parent page (dnnsoftware#2925) * DNN-31366 - TabController HasChildren returns false if all children are deleted * Simplify HasChildren condition * deleting_themes_from_Extensions_doesnt_remove_it_from_themes (dnnsoftware#2950) * Returns the working types if some fail (dnnsoftware#2953)
Closes #2952
Previously if one type in an assembly was failing, all the types of that assembly where ignored by the startup code. This PRs fixes this and returns all the other types to prevent odd behaviours.