Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console error displayed for missing gif file associated with missing language flag images #3384

Merged
merged 4 commits into from
Dec 9, 2019

Conversation

berkarslan-xo
Copy link
Contributor

Fixes #3383

Summary

An empty flag is returned if the related culture's flag is not found.

Demo: https://drive.google.com/file/d/1O8AD98BsMVhDegMUyOAQkz9H23QWcJc4/view?usp=sharing

@bdukes bdukes changed the base branch from release/9.4.x to develop December 6, 2019 15:11
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@valadas valadas added this to the 9.5.0 milestone Dec 9, 2019
@valadas valadas changed the title DNN-30122 - Console error displayed for missing gif file associated with European English Console error displayed for missing gif file associated with missing language flag images Dec 9, 2019
@valadas valadas merged commit 4433260 into dnnsoftware:develop Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console error displayed for missing gif file associated with European English
3 participants