Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves Email + Display Name on Registration Form & Email in User.ascx file above Username/Password on #3386

Merged
merged 2 commits into from
Dec 14, 2019

Conversation

thabaum
Copy link
Contributor

@thabaum thabaum commented Dec 6, 2019

#3371 #3372

Summary

Moves Email above Username in User.ascx.cs to match order of Users.aspx
Moves Registration Email Field above Username on the Registration Form.

…d Fields

Lines 219 &220 + 670 &671 ?.?  are they cut off intentionally offset or is it just a github bug...
@thabaum thabaum changed the title Patch 17 Moves Email above Username in User.ascx.cs file and on the Registration Form Dec 6, 2019
@thabaum thabaum changed the title Moves Email above Username in User.ascx.cs file and on the Registration Form Moves Email + Display Name above Username/Password on Registration page and Email for User.ascx file Dec 8, 2019
@thabaum thabaum changed the title Moves Email + Display Name above Username/Password on Registration page and Email for User.ascx file Moves Email + Display Name above Username/Password on Registration Form & Email in User.ascx file Dec 8, 2019
@thabaum thabaum changed the title Moves Email + Display Name above Username/Password on Registration Form & Email in User.ascx file Moves Email + Display Name on Registration Form & Email in User.ascx file above Username/Password on Dec 8, 2019
@valadas valadas added the chore label Dec 10, 2019
@valadas valadas added this to the 9.5.0 milestone Dec 10, 2019
@donker
Copy link
Contributor

donker commented Dec 10, 2019

Hey @thabaum, does this change anything? It looks like it just moved stuff in code, not in UI, right?

@thabaum
Copy link
Contributor Author

thabaum commented Dec 13, 2019

@donker The registration form is created in code making it hard to see. This is pretty much two related PR's in one.

The first one just moves in logical order email above username in the User.aspx with the last PR that was related "Chore". It really does nothing but make sense when you look the order in the code.

"&"

"Enhancement" or "Chore" as well secondly this actually moves the email+display name on the registration form. I dug all over trying to find it please correct me if I am wrong but the Display Name and email Registration HTML will be parsed prior to username and password fields on the registration form if this PR is accepted. I am hoping I got this part 100% right as this is my main intention with this PR. Otherwise it just moves things around in code.

Copy link
Contributor

@donker donker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me

@donker donker merged commit 973972d into dnnsoftware:develop Dec 14, 2019
@valadas
Copy link
Contributor

valadas commented Dec 17, 2019

Yep that should do it @thabaum

@thabaum thabaum deleted the patch-17 branch December 7, 2021 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants