Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automates generation of .sqlDataProvider file #3419

Merged
merged 3 commits into from
Dec 31, 2019
Merged

Automates generation of .sqlDataProvider file #3419

merged 3 commits into from
Dec 31, 2019

Conversation

valadas
Copy link
Contributor

@valadas valadas commented Dec 24, 2019

Summary

  • Removes the hardcoded tools version 2017 which prevented building if you only have Visual Studio 2019 and never had 2017
  • Automates the generation of the xx.xx.xx.sqlDataProvider file to prevent and upgrade loop if we forget to create that file.

Closes #3296

@valadas valadas added the chore label Dec 24, 2019
@valadas valadas added this to the 9.5.0 milestone Dec 24, 2019
david-poindexter
david-poindexter approved these changes Dec 25, 2019
View reviewed changes
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @valadas!

mitchelsellers
mitchelsellers approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitchelsellers mitchelsellers merged commit 5013438 into dnnsoftware:develop Dec 31, 2019
@valadas valadas deleted the issue/3296 branch February 15, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohine ohine ohine approved these changes

@david-poindexter david-poindexter david-poindexter approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

Assignees
No one assigned
Labels
Type: Build/Release
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

9.4.3 upgrade fails due to missing 09.04.03.SqlDataProvider
4 participants
@valadas @ohine @david-poindexter @mitchelsellers