Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed alias of added language #3445

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Fixed alias of added language #3445

merged 1 commit into from
Jan 2, 2020

Conversation

daguiler
Copy link
Contributor

@daguiler daguiler commented Jan 2, 2020

Fixes #3444

Summary

When adding new languages, I'm adding following fallback logic to select the base URL for the new aliases:

  1. pick first culture-neutral, primary alias
  2. pick first culture-neutral, non-primary alias
  3. just pick the first one (the strategy before this change)

mitchelsellers
mitchelsellers approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@david-poindexter david-poindexter added this to the 9.5.0 milestone Jan 2, 2020
@david-poindexter david-poindexter merged commit b591be0 into dnnsoftware:develop Jan 2, 2020
@daguiler daguiler deleted the fix-portal-alias-creation branch January 2, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-poindexter david-poindexter david-poindexter approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

Wrong portal alias is created when adding new languages
3 participants
@daguiler @david-poindexter @mitchelsellers