Issues/3455 lerna build #3456
Merged
Issues/3455 lerna build #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 8, 2020 14:25
|
Thanks for taking a look at this @mtrutledge! These changes make sense, but it looks like the CI build is still failing. If you need an extra set of eyes, I'm always happy to help! |
|
Taking a look to see why the CI build is failing. It almost looks like the export bundle is trying to compile the dnn-react-common that is already compiled instead of just packaging it. |
added 2 commits
January 9, 2020 16:05
donker
approved these changes
Jan 11, 2020
valadas
added a commit
to valadas/Dnn.Platform
that referenced
this pull request
Jan 11, 2020
valadas
added a commit
to valadas/Dnn.Platform
that referenced
this pull request
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3455
Summary
Made sure that lerna knew about the workspace packages configured for yarn. Had to move React Common to the top to make sure it was built first. Also added scripts to the main package.json for a cleaner interface instead of calling lerna directly from msbuild.