Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose file last modifed date/time via cachebusted URLs #3528

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Don't expose file last modifed date/time via cachebusted URLs #3528

merged 1 commit into from
Jan 30, 2020

Conversation

roman-yagodin
Copy link
Contributor

Closes #2850

@dnfclas
Copy link

dnfclas commented Jan 29, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

mitchelsellers
mitchelsellers requested changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This request includes a new feature that is a PortalSetting but does not expose any UI for it. We will need to get a UI for this before we can accept it.

@bdukes
Copy link
Contributor

bdukes commented Jan 30, 2020

❓ I don't see any new portal setting when I look at the diff. Am I missing something @mitchelsellers?

mitchelsellers
mitchelsellers approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, apparently GitHub's diff showed a different location of additions. This looks good

@mitchelsellers
Copy link
Contributor

@bdukes GitHub's diff display was being stupid

@mitchelsellers mitchelsellers added this to the 9.5.0 milestone Jan 30, 2020
@bdukes bdukes merged commit 143b187 into dnnsoftware:development Jan 30, 2020
@bdukes
Copy link
Contributor

bdukes commented Jan 30, 2020

Thanks @roman-yagodin!

@bdukes bdukes mentioned this pull request Jan 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdukes bdukes bdukes approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

Assignees
No one assigned
Labels
Effort: Low Priority: Medium Type: Enhancement
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@roman-yagodin @dnfclas @bdukes @mitchelsellers