Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persona bar: Show page title on hover, show more of long page titles #3569

Merged
merged 3 commits into from
Feb 17, 2020
Merged

Persona bar: Show page title on hover, show more of long page titles #3569

merged 3 commits into from
Feb 17, 2020

Conversation

OllyHodgson
Copy link
Contributor

Fixes #3090.

  1. No longer truncates the page name. This means screen readers should be able to read the entire page name.
  2. Handles the text-overflow using CSS.
  3. Adds the page name to the title attribute of the list item. Most desktop browsers will show this when hovering over the page name.
  4. Tightens up the spacing a little, so slightly longer page titles fit. I'm pretty sure there's more we can do here, but I think this is a decent start.

I've tested in latest Chrome, Edge (Chromium) and Firefox. Could do with testing in a wider variety of browsers.

Summary

@dnfclas
Copy link

dnfclas commented Feb 16, 2020

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @OllyHodgson

@david-poindexter david-poindexter merged commit 302d787 into dnnsoftware:develop Feb 17, 2020
@valadas
Copy link
Contributor

valadas commented Feb 17, 2020

Nice one, thanks!

@OllyHodgson OllyHodgson deleted the issue-3090 branch February 18, 2020 16:42
@valadas valadas modified the milestones: 9.5.1, 9.6.0 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long page titles are cropped in the Pages editor (UX enahncement)
5 participants