Add debug build to lerna #3596
Merged
Add debug build to lerna #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-poindexter
approved these changes
Feb 27, 2020
|
I didnt merge this because the Compress images / build (pull_request) failed with the error 'The repository 'http://security.ubuntu.com/ubuntu cosmic-security Release' does not have a Release file.' @valadas any ideas on that? |
|
hmm, yes and no, Azure pipelines is succeeding, the github action to minimize images if failing, I will have to take a look at it, I will take a look when I come back from Orlando... That being said, if there is any rush in merging this, i can force it if needed, just ping me up, all the reset passes. |
|
@donker it's not letting me rebase this branch on git checkout adddebug
git fetch --all
git rebase upstream/adddebug # assuming your dnnsoftware branch is named upstream
git push --force-with-lease origin adddebug # assuming your donker branch is named origin |
|
All green now, merging this. |
valadas
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was overlooked in the last Lerna/Yarn overhaul. The user must be able to target a local dev site with the Lerna build. It is currently missing as it only runs in production mode.