Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue with backup/restore in build #3615

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

valadas
Copy link
Contributor

@valadas valadas commented Mar 6, 2020

Closes #3613

As part of the build process we do a backup commit when the build starts
then we revert 1 commit up to bring back the files at excatly the point
they where before the build. This works nice when there are any files
to commit but not when there is nothing to commit.
This PR resolves that by adding the --allow-empty flag to the backup
commit.

Closes dnnsoftware#3613

As part of the build process we do a backup commit when the build starts
then we revert 1 commit up to bring back the files at excatly the point
they where before the build. This works nice when there are any files
to commit but not when there is nothing to commit.
This PR resolves that by adding the --allow-empty flag to the backup
commit
@valadas valadas added this to the 9.5.1 milestone Mar 6, 2020
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and was successful

Copy link
Contributor

@donker donker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@donker donker merged commit b99958e into dnnsoftware:develop Mar 6, 2020
@valadas valadas modified the milestones: 9.5.1, 9.6.0 Apr 14, 2020
@valadas valadas deleted the fix-build-backup branch April 14, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed builds revert one commit too far (backup task)
3 participants