Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed widget.js 404 error #3631

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Conversation

daguiler
Copy link
Contributor

Fixes #3630

Summary

The updated jquery.fileupload.js file changed the way it references the widget factory from this:

if (typeof define === 'function' && define.amd) {
  // Register as an anonymous AMD module:
  define([
    'jquery',
    'jquery.ui.widget'
  ], factory);
} else ...

to this:

if (typeof define === 'function' && define.amd) {
  // Register as an anonymous AMD module:
  define([
    'jquery',
    'jquery-ui/ui/widget'
  ], factory);
} else ...

and since this standalone jquery-ui/ui/widget.js file doesn't exist, it returns a 404, causing dependent modules to fail. The needed widget factory is actually included in the jquery-ui.min.js file.
After reverting this path, the module loads fine again:

DNN-37504-4

@david-poindexter david-poindexter added this to the 9.5.1 milestone Mar 18, 2020
@valadas valadas modified the milestones: 9.5.1, 9.6.0 Mar 18, 2020
@valadas valadas merged commit c2f26e0 into dnnsoftware:develop Mar 18, 2020
@daguiler daguiler deleted the bugfix/DNN-37504 branch March 18, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jquery.fileupload broken after update
4 participants