Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow (super)users to log in to portals that have email as username #3659

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Allow (super)users to log in to portals that have email as username #3659

merged 2 commits into from
Apr 7, 2020

Conversation

donker
Copy link
Contributor

@donker donker commented Apr 2, 2020 •
edited
Loading

Summary

This fixes issues #3658 and #3660 by

  1. allowing a superuser to also be returned from the GetSingleUserByEmail SPROC even though they might not ba a member of the portal.
  2. Ensuring we user EffectivePortalId when looking up a user by email in the login logic

@donker donker added this to the 9.6.0 milestone Apr 2, 2020
@donker donker changed the title Fixes #3658 by allowing a superuser to be returned for this query Fixes #3658 allowing (super)users to log in to portals that have email as username Apr 2, 2020
@donker donker changed the title Fixes #3658 allowing (super)users to log in to portals that have email as username Allow (super)users to log in to portals that have email as username Apr 2, 2020
@bdukes bdukes merged commit f83988d into dnnsoftware:develop Apr 7, 2020
@donker donker mentioned this pull request Apr 9, 2020
Closed
@donker donker deleted the bug3658 branch April 12, 2020 12:13
@bdukes bdukes mentioned this pull request Apr 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdukes bdukes bdukes approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

Assignees
No one assigned
Labels
Area: Platform > Library Type: Bug
Projects
None yet
Milestone
9.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@donker @bdukes @mitchelsellers