Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource Manager Standardization & Improvement #3734

Merged
merged 5 commits into from
May 6, 2020
Merged

Resource Manager Standardization & Improvement #3734

merged 5 commits into from
May 6, 2020

Conversation

mitchelsellers
Copy link
Contributor

This is the result of an initial code review working to provide consistency in the code for the Resource Manager. The following actions were taken.

  • Addition of required headers to all files
  • Removed unused code from various methods
  • Improved security in a number of locations

donker
donker approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@donker donker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@donker donker added this to the 9.7.0 milestone May 6, 2020
@donker donker merged commit 7a90240 into dnnsoftware:feature/resource-manager May 6, 2020
@valadas valadas modified the milestones: 9.7.0, 9.8.0 Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdukes bdukes bdukes approved these changes

@donker donker donker approved these changes

Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
9.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mitchelsellers @bdukes @donker @valadas