Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More StyleCop fixes #3843

Merged
merged 14 commits into from
Jun 17, 2020
Merged

More StyleCop fixes #3843

merged 14 commits into from
Jun 17, 2020

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Jun 16, 2020

It's the gift that keeps on giving.

@valadas valadas added this to the 9.6.2 milestone Jun 17, 2020
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A spot check did not reveal anything odd. Looks good to me.

You are on fire @bdukes

@donker donker merged commit f1397aa into dnnsoftware:develop Jun 17, 2020
valadas added a commit to valadas/Dnn.Platform that referenced this pull request Jul 27, 2020
Closes dnnsoftware#3906

Apparently some files where deleted as part of dnnsoftware#3843

This PR brings those files back and also fixes stylecop warnings. Some class names had to be changed both for clarity and to respect stylecop rule that the file name should match the class name. Because of that change, the dnn manifest was also changed so it all works with the new names.
david-poindexter pushed a commit that referenced this pull request Jul 27, 2020
* Resolves 9.6.2 logging issue.

Closes #3906

Apparently some files where deleted as part of #3843

This PR brings those files back and also fixes stylecop warnings. Some class names had to be changed both for clarity and to respect stylecop rule that the file name should match the class name. Because of that change, the dnn manifest was also changed so it all works with the new names.

* fixes one missed ref in manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants